Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1366 ln -sf leaving tmp files lying around #1367

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix #1366 ln -sf leaving tmp files lying around #1367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2e922
fix #1366 ln -sf leaving tmp files lying around
petersilva Jan 8, 2025
cb08311
explaining the fix
petersilva Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sarracenia/flow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,7 +1618,8 @@ def renameOneItem(self, old, path) -> bool:
for messages with an rename file operation, it is to rename a file.
"""
ok = True
if not os.path.exists(old):
# it turns out that links that exist but point to non-existent files return exists: False.
if not os.path.islink(old) and not os.path.exists(old):
logger.info(
"old file %s not found, if destination (%s) missing, then fall back to copy"
% (old, path))
Expand Down
Loading