sr3 status fixes #1350 and #1352. #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem was that there were multiple conditions to check to assign one of the new states and if the multiple conditions did not result in "down" or "disconnected" state... it would skip over a number of checks for *idle* state. So moved all the new states to a separate if above the exising series.
petersilva
requested review from
reidsunderland,
junhu3,
andreleblanc11 and
mshak2
Test Results5 tests 0 ✅ 18s ⏱️ For more details on these errors, see this check. Results for commit 68fc9e9. |
MagikEh
reviewed
Dec 20, 2024
MagikEh
approved these changes
Dec 20, 2024
|
Very alphabet (google owns me) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1352
close #1350
For #1350, there was a tally missing from empry_metrics so that the post_retries were not being counted.
For #1350, added two states, disconnected is for when communications with the broker is broken. down is when data transfer connection is broken.
seems to work.