Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1299 - New after_gather entry point + better error handling in sundew_dirPattern #1308

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

andreleblanc11
Copy link
Member

@andreleblanc11 andreleblanc11 commented Nov 28, 2024

  • Added a new flow callback entry point + documentation.

    • I'm not 100% sure the location where I added after_gather is correct. I put it before runCallbackPoll is called because there's if self.o.component != 'poll': that comes just after.
    • So far, it seems that only sarra configs benefit of after_gather. Placement might be fine.
  • Better error handling of sundew_dirPattern by wrapping it in a try/except.

    • updateFieldsAccepted now returns a boolean.
  • I updated the raw2bulletin renamer to use relPath instead of new_file/new_dir. There's no new_dir/new_file before the filtering.

  • I've also updated the unit tests and have ran the AM flow test. Both look OK now.

Copy link

github-actions bot commented Nov 28, 2024

Test Results

238 tests   235 ✅  1m 29s ⏱️
  1 suites    1 💤
  1 files      2 ❌

For more details on these failures, see this check.

Results for commit bf72691.

♻️ This comment has been updated with latest results.

@petersilva
Copy link
Contributor

I approved it, but there are conflicts... can you fix them in your branch so it will apply cleanly?

@andreleblanc11
Copy link
Member Author

I thought I had already resolved the merge conflicts in af725c6?

It doesn't look like there are any more conflicts

@petersilva petersilva merged commit a4af0e2 into development Dec 1, 2024
31 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with sundew pattern matching when filename is ambiguous
2 participants