Json logging (EXPERIMENTAL) #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
tysonkaufmann,
andreleblanc11 and
mshak2
Test Results249 tests 246 ✅ 1m 34s ⏱️ For more details on these failures, see this check. Results for commit d4efdd7. ♻️ This comment has been updated with latest results. |
|
purpose of this experimental feature is to let people kick the tires. it is documented as EXPERIMENTAL ... meaning we may remove it in a future release, or it could change... it is just to people to comment on for now. |
reidsunderland
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #716
This option adds a flag to enable json formatted logging.
It has been requested by several people. but the problem was that
some of the text stuff currently being logged isn't log messages, just random
stdout of subprocesses (e.g. scp, wget) which will give a json parser fits.
So just made a second log file (with .json suffix) and tools that prefer that
can ingest that. the txt log remains... so it logs twices as much.
experimental enabling of json formatted logging.
Does this make any sense?