Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realpath_post_baseDir for #140 #186

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add realpath_post_baseDir for #140 #186

merged 2 commits into from
Nov 20, 2024

Conversation

reidsunderland
Copy link
Member

Also fixes #185.

Any time sr_cfg->post_baseDir is set, I also set sr_cfg->realpath_post_baseDir from realpath(sr_cfg->post_baseDir).

This is my first time changing sr_config.c/h and sr_post.c, I've only worked in libsr3shim.c before. Please review carefully 😄

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. tested in on HPC env. with make test_shim_post and got zero errors... so it definitely addresses the original issue.

@petersilva petersilva merged commit 7da1389 into development Nov 20, 2024
10 of 12 checks passed
@reidsunderland reidsunderland deleted the issue140_rs branch November 20, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If post_baseDir ends in /, the relPaths are wrong
2 participants