Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue111 5 code cleanups that do not solve any problems, but perhaps prevent undiscoverred ones. #184

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

petersilva
Copy link
Contributor

while working on #111, found many random problems that did not cause obvious issues... but they are still wrong.
If we don't fix them now, eventually they will provoke issues so might was well be pro-active:

  • there were some situations where errno was not set properly returning an error status (operation failed.)
  • in exit_cleanup_posts() we want to post files that were not closed... but not sockets, or pipes, or devices, or... so test if it is a REGULAR file, and only do further work on those.
  • with valgrind, found a memory "leak" (harmless) ... but fixed to reduce qvetching.
  • error message about config file not found was not listing the obvious, normal place to look... It did look there, but the message said it didn't.... fixed that.
  • earlier patch made exit_clieanup skip stderr... to get more error messages during process exit. That is great when debugging process exit, but normally, processes don't need that, and they want to post their stderr... so ideally should post it. but it is often needed when debugging. so made SR_SHIMDEBUG=128 trigger that behaviour.

@petersilva petersilva changed the title Issue111 5 Issue111 5 code cleanups that do not solve any problems, but perhaps prevent undiscoverred ones. Nov 18, 2024
Copy link
Member

@andreleblanc11 andreleblanc11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the commits, and I think it looks OK.

@petersilva petersilva merged commit 2a5bd5c into development Nov 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants