Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue148 - posting corrupt topic header in rare case (but common in tests.) #149

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Issue148 - posting corrupt topic header in rare case (but common in tests.) #149

merged 4 commits into from
Jul 17, 2024

Conversation

petersilva
Copy link
Contributor

  • this is a confluence of two things that happenned over the past year: added directory postings, and forcing relPath is always relative.
  • If you want to post a message at the root of a baseURL tree, the correct relPath is an empty string.
  • relPath is used to derive the topic, and copies garbage into the topic when relPath is too short.
  • It's only multiple patches because I hemmed and hawed about how to do it. Also updated changelog to reflect @reidsunderland 's recently merged PR as well as this one.

This problem causes a lot of flow tests to fail.

@petersilva petersilva merged commit 7a3249e into development Jul 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidsunderland reidsunderland reidsunderland approved these changes

@MagikEh MagikEh Awaiting requested review from MagikEh

@tysonkaufmann tysonkaufmann Awaiting requested review from tysonkaufmann

@andreleblanc11 andreleblanc11 Awaiting requested review from andreleblanc11

@mshak2 mshak2 Awaiting requested review from mshak2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petersilva @reidsunderland