Revert "Deploy configuration daemon DS during config template reconcile" #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13132265813Details
💛 - Coveralls |
|
Agree with the approach |
almaslennikov
force-pushed
the
revert-changes-for-ocp
branch
2 times, most recently
from
c293a7f to
53bcf7c
Compare
Since we've decided not to support a separate OCP bundle for NIC op, let's drop the elaborate daemon deployment scheme and keep deploying both the operator and the daemon set together from the helm chart This reverts commit cedb2e3. Revert "Add a config map with config daemon config to the helm chart" This reverts commit 165b226.
almaslennikov
force-pushed
the
revert-changes-for-ocp
branch
from
53bcf7c to
bf5e165
Compare
ykulazhenkov
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've decided not to support a separate OCP bundle for NIC op, let's drop the elaborate daemon deployment scheme and keep deploying both the operator and the daemon set together from the helm chart
This reverts commit cedb2e3.
Original PR: #55