canvas implementation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ragging and zooming
- Adjusted the canvas resize logic to ensure proportional scaling of elements when the window is resized or zoomed. - Fixed issues with sidebars affecting canvas width and height dynamically using offsetWidth and offsetHeight. - Corrected the edge connections between devices to update correctly when dragging and repositioning nodes. - Improved viewport scaling to maintain element proportions during zooming or resizing events.
…evices - Implemented save/load functionality, allowing the graph state to be saved as JSON and reloaded. - Added save and load buttons to trigger the respective functionality. - Adjusted the drawing logic for connections to ensure they don't overlap device icons. - Connections now start and end at the edges of device icons instead of their center points.
MegaRedHand
reviewed
Oct 26, 2024
src/index.ejs
Outdated
Comment on lines
12
to
13
| <button id="save-button" class="save-button" title="Save">Save</button> | ||
| <button id="load-button" class="load-button" title="Load">Load</button> |
There was a problem hiding this comment.
Let's change this to Guardar and Cargar
src/index.ejs
Outdated
| <div id="right-bar" class="right-bar"> | ||
| <h2>Información</h2> | ||
| <div id="info-content"> | ||
| <!-- Información dinámica sobre el conejo y los routers se mostrará aquí --> |
There was a problem hiding this comment.
Let's change this comment to english
src/index.ts
Outdated
|
|
||
| // Add router button | ||
| leftBar.addButton(RouterSvg, () => { | ||
| AddRouter(ctx); // Esta es una función anónima que ejecuta AddRouter cuando se hace clic |
There was a problem hiding this comment.
Let's change these comments to english
src/types/networkgraph.ts
Outdated
| console.warn(`El dispositivo con ID ${n2Info.id} no existe en devices.`); | ||
| } else { | ||
| // Verificar si ya existe una arista entre estos dos dispositivos | ||
| for (const edge of this.edges.values()) { |
There was a problem hiding this comment.
Let's mark this part for later refactoring. This for goes through ALL edges on the graph. It will probably bring performance issues in the future.
src/types/viewportManager.ts
Outdated
Comment on lines
139
to
140
| newNode.sprite.x = nodeData.x; | ||
| newNode.sprite.y = nodeData.y; |
There was a problem hiding this comment.
We should pass this as a constructor parameter.
src/index.ts
Outdated
Comment on lines
229
to
245
| const input = document.createElement("input"); | ||
| input.type = "file"; | ||
| input.accept = ".json"; | ||
|
|
||
| input.onchange = (event) => { | ||
| const file = (event.target as HTMLInputElement).files[0]; | ||
| const reader = new FileReader(); | ||
| reader.readAsText(file); | ||
|
|
||
| reader.onload = (readerEvent) => { | ||
| const jsonData = readerEvent.target.result as string; | ||
| loadGraph(jsonData, ctx); // Llama a la función loadGraph pasando el JSON y el contexto | ||
| }; | ||
| }; | ||
|
|
||
| input.click(); // Simula el click para abrir el cuadro de diálogo de selección de archivo | ||
| }; |
There was a problem hiding this comment.
The saveButton and loadButton not being simmetric smells. This should either go inside loadGraph, or we should take out the save-to-file logic inside saveGraph.
MegaRedHand
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.