feat: echo-reply sent when receiving an echo-request. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: - "Send ICMP Echo" program changed to "Send ping". - refactor on packet ought to be done. - Running "Echo-server" program releases too many echo-replies.
Main changes: - The raw packet is received by sendPacke. - The reception and handling of a packet logic is in Device. Known bugs/issues: - When receiving a packet from a removed device, the current device does not send the reply back. It might be better if it send back the reply and let the packet "get lost" in the middle.
MegaRedHand
approved these changes
Feb 1, 2025
Comment on lines
+120
to
+121
| // Packet protocol name | ||
| getPacketType(): string; |
There was a problem hiding this comment.
I don't think this is the place for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.