Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7850 QDM Test case is Failing when it should PASS #746

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

adongare
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7850
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@adongare adongare changed the base branch from develop to kayak_hotfix October 24, 2024 18:50
@adongare adongare marked this pull request as ready for review October 24, 2024 18:50
@adongare adongare requested a review from a team as a code owner October 24, 2024 18:50
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b676a591
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b676a59) Report Missing Report Missing Report Missing
Head commit (73640be) 5674 4993 88.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#746) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.13% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (512e626) 5660 4988 88.13%
Head commit (73640be) 5674 (+14) 4993 (+5) 88.00% (-0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#746) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (kayak_hotfix@b676a59). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             kayak_hotfix     #746   +/-   ##
===============================================
  Coverage                ?   82.97%           
===============================================
  Files                   ?      205           
  Lines                   ?     6157           
  Branches                ?     1334           
===============================================
  Hits                    ?     5109           
  Misses                  ?      717           
  Partials                ?      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adongare adongare merged commit 832d120 into kayak_hotfix Oct 24, 2024
12 of 13 checks passed
@adongare adongare deleted the kayak_hotfix_MAT-7850 branch October 24, 2024 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant