Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7684 UnsignedInt and MAT-7685 PositiveInt #727

Merged
merged 15 commits into from
Oct 28, 2024

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Oct 14, 2024

MADiE PR

Jira Ticket: MAT-7684
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner October 14, 2024 11:27
@sb-cecilialiu sb-cecilialiu requested review from a team and removed request for a team October 14, 2024 11:27
Copy link

codacy-production bot commented Oct 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.15% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8f64976) 5672 4992 88.01%
Head commit (bc914b4) 5692 (+20) 5018 (+26) 88.16% (+0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#727) 28 28 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (64605f9) to head (0436e52).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #727      +/-   ##
===========================================
+ Coverage    82.98%   83.19%   +0.20%     
===========================================
  Files          205      205              
  Lines         6155     6178      +23     
  Branches      1334     1346      +12     
===========================================
+ Hits          5108     5140      +32     
+ Misses         716      709       -7     
+ Partials       331      329       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkotanchik-SB
jkotanchik-SB previously approved these changes Oct 17, 2024
@nmorasb
Copy link
Contributor

nmorasb commented Oct 17, 2024

how will these refactors handle a signed integer? (Just a regular int that can be positive, 0 or negative) per https://jira.cms.gov/browse/MAT-7671

@sb-cecilialiu sb-cecilialiu merged commit 68e4bd2 into develop Oct 28, 2024
11 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7685_PositiveInt branch October 28, 2024 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants