Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7775: add data element code for birthdate #726

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

chubert-sb
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7775
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@chubert-sb chubert-sb requested a review from a team as a code owner October 11, 2024 23:03
Copy link

codacy-production bot commented Oct 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (79c7aa2) 5640 4939 87.57%
Head commit (1ee5e8c) 5645 (+5) 4943 (+4) 87.56% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#726) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (79c7aa2) to head (1ee5e8c).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
...l/ElementsTab/Demographics/DemographicsSection.tsx 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #726      +/-   ##
===========================================
- Coverage    82.71%   82.69%   -0.02%     
===========================================
  Files          205      205              
  Lines         6114     6119       +5     
  Branches      1321     1322       +1     
===========================================
+ Hits          5057     5060       +3     
- Misses         736      737       +1     
- Partials       321      322       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mcmcphillips mcmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@chubert-sb chubert-sb merged commit 3ef44d5 into develop Oct 15, 2024
11 of 13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants