Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Feature/mat 7666 fhir service updates for QICore test case builder #725

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Oct 11, 2024

MADiE PR

Jira Ticket: MAT-7666
(Optional) Related Tickets:

Summary

  • Switch QICore Builder from PoC server to madie-fhir-service
  • Add support for profile and add profile to resource on selection
  • Add PoC Codes component
  • Update tests

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

…service; added PoC Codes component; updating tests; add profile to bundle resource on create
…service; added PoC Codes component; updating tests; add profile to bundle resource on create; merge down develop
@nmorasb nmorasb requested a review from a team October 11, 2024 13:24
Copy link

codacy-production bot commented Oct 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.37% 25.64%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (acae206) 5614 4937 87.94%
Head commit (09cd321) 5642 (+28) 4941 (+4) 87.58% (-0.37%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#725) 39 10 25.64%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nmorasb nmorasb marked this pull request as ready for review October 11, 2024 13:32
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (acae206) to head (09cd321).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ementsTab/builder/element/types/CodesComponent.tsx 6.25% 15 Missing ⚠️
src/api/useFhirDefinitionsService.ts 25.00% 6 Missing ⚠️
...e/qiCore/LeftPanel/ElementsTab/builder/Builder.tsx 25.00% 6 Missing ⚠️
...anel/ElementsTab/builder/resource/ResourceList.tsx 66.66% 1 Missing and 1 partial ⚠️
...ftPanel/ElementsTab/builder/element/TypeEditor.tsx 0.00% 1 Missing ⚠️
.../ElementsTab/builder/resource/ResourceListTile.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #725      +/-   ##
===========================================
- Coverage    83.02%   82.68%   -0.35%     
===========================================
  Files          204      205       +1     
  Lines         6087     6116      +29     
  Branches      1316     1323       +7     
===========================================
+ Hits          5054     5057       +3     
- Misses         711      736      +25     
- Partials       322      323       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmorasb nmorasb merged commit f0dce2e into develop Oct 14, 2024
11 of 13 checks passed
@nmorasb nmorasb deleted the feature/MAT-7666-fhir-service-updates branch October 14, 2024 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants