Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7662: Ignore partial dateTime entries by checking MUI validation results. #720

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Oct 8, 2024

MADiE PR

Jira Ticket: MAT-7662
(Optional) Related Tickets:

Summary

Ignores partial DateTime entries on Test Cases by checking the MUI validation result.

Allows users to null out populated dateTime values.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner October 8, 2024 21:10
@jkotanchik-SB jkotanchik-SB self-assigned this Oct 8, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7480-handle-partial-datetime-inputs branch from e691771 to 8f64ed9 Compare October 8, 2024 21:13
Copy link

codacy-production bot commented Oct 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% 90.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eea5147) 5571 4898 87.92%
Head commit (d64b290) 5570 (-1) 4901 (+3) 87.99% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#720) 10 9 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7480-handle-partial-datetime-inputs branch from 8f64ed9 to 4adc47b Compare October 8, 2024 21:17
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (eea5147) to head (d64b290).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../components/common/dateTimeInput/DateTimeInput.tsx 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #720      +/-   ##
===========================================
+ Coverage    82.94%   83.08%   +0.14%     
===========================================
  Files          203      203              
  Lines         6039     6037       -2     
  Branches      1296     1295       -1     
===========================================
+ Hits          5009     5016       +7     
+ Misses         706      702       -4     
+ Partials       324      319       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkotanchik-SB jkotanchik-SB changed the title MAT-7480: Ignore partial dateTime entries by checking MUI validation results. MAT-7662: Ignore partial dateTime entries by checking MUI validation results. Oct 9, 2024
…results.

Allow user to null out populated dateTime values.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7480-handle-partial-datetime-inputs branch from 4adc47b to d64b290 Compare October 9, 2024 14:26
@jkotanchik-SB jkotanchik-SB merged commit 9278615 into develop Oct 9, 2024
12 of 13 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7480-handle-partial-datetime-inputs branch October 9, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants