Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-6516: adding test coverage #517

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Dec 6, 2023

MADiE PR

Jira Ticket: MAT-6516
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@nmorasb nmorasb requested a review from a team December 6, 2023 22:18
@nmorasb nmorasb marked this pull request as ready for review December 6, 2023 22:23
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9df284a) 87.61% compared to head (288e366) 87.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #517      +/-   ##
===========================================
+ Coverage    87.61%   87.65%   +0.04%     
===========================================
  Files          163      163              
  Lines         4666     4665       -1     
  Branches      1051     1050       -1     
===========================================
+ Hits          4088     4089       +1     
+ Misses         318      317       -1     
+ Partials       260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9df284a) 4301 4004 93.10%
Head commit (288e366) 4300 (-1) 4004 (+0) 93.12% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#517) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@nmorasb nmorasb merged commit 770eef9 into develop Dec 7, 2023
9 checks passed
@nmorasb nmorasb deleted the feature/MAT-6516-delete-all-tcs-testing branch December 7, 2023 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants