Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-6006,6007,6008 added Used, Unused and Functions to QDM Highlighti… #510

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6006,MAT-6007,MAT-6008
(Optional) Related Tickets:

Summary

added Used, Unused and Functions to QDM Highlighting Tab

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner December 3, 2023 18:41
Copy link

codacy-production bot commented Dec 3, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% 92.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (359520e) 4336 4027 92.87%
Head commit (3e55d8d) 4400 (+64) 4085 (+58) 92.84% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#510) 70 65 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: Patch coverage is 84.93151% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (359520e) to head (3e55d8d).
Report is 1017 commits behind head on develop.

Files with missing lines Patch % Lines
src/api/useCqlParsingService.ts 0.00% 5 Missing ⚠️
...ts/editTestCase/groupCoverage/QdmGroupCoverage.tsx 88.88% 0 Missing and 5 partials ⚠️
...ghtPanel/calculationResults/CalculationResults.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
- Coverage    87.46%   87.34%   -0.13%     
===========================================
  Files          164      168       +4     
  Lines         4700     4766      +66     
  Branches      1053     1065      +12     
===========================================
+ Hits          4111     4163      +52     
- Misses         330      336       +6     
- Partials       259      267       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkotanchik-SB
jkotanchik-SB previously approved these changes Dec 4, 2023
@sb-prateekkeerthi sb-prateekkeerthi merged commit 7a5f3a9 into develop Dec 11, 2023
7 of 9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants