Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-5980: implement qdm test case import warning alert #507

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

mcmcphillips
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-5980
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@mcmcphillips mcmcphillips requested a review from a team as a code owner November 29, 2023 19:26
@mcmcphillips mcmcphillips changed the title MAT-5980: implement qdm warning dialog MAT-5980: implement qdm test case import warning alert Nov 29, 2023
Copy link

codacy-production bot commented Nov 29, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6ddc72e) 4251 3956 93.06%
Head commit (725c6ee) 4262 (+11) 3967 (+11) 93.08% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#507) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6ddc72e) 87.46% compared to head (725c6ee) 87.49%.

Files Patch % Lines
src/components/routes/qdm/TestCaseRoutes.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #507      +/-   ##
===========================================
+ Coverage    87.46%   87.49%   +0.03%     
===========================================
  Files          163      163              
  Lines         4618     4630      +12     
  Branches      1047     1050       +3     
===========================================
+ Hits          4039     4051      +12     
  Misses         316      316              
  Partials       263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips mcmcphillips merged commit 3dceb98 into develop Nov 30, 2023
9 checks passed
@mcmcphillips mcmcphillips deleted the MAT-5980 branch November 30, 2023 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants