Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Feature/mat 5981 #506

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Feature/mat 5981 #506

merged 3 commits into from
Nov 29, 2023

Conversation

RohitKandimalla
Copy link
Contributor

@RohitKandimalla RohitKandimalla commented Nov 28, 2023

MADiE PR

Jira Ticket: MAT-5981
(Optional) Related Tickets:

Summary

  • Edit Action button is added to edit previously added QDM DataElements
  • For non owners, the popover menu option is removed, so it will be only a single button "View", on clicks opens the non-editable DataElementCard
  • New Test suite is added for DE Table Actions

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@RohitKandimalla RohitKandimalla self-assigned this Nov 28, 2023
@RohitKandimalla RohitKandimalla requested a review from a team as a code owner November 28, 2023 19:08
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (15e0f5f) 4233 3936 92.98%
Head commit (7f1d6b7) 4233 (+0) 3938 (+2) 93.03% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#506) 16 16 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.47%. Comparing base (15e0f5f) to head (7f1d6b7).
Report is 1096 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #506      +/-   ##
===========================================
+ Coverage    87.38%   87.47%   +0.08%     
===========================================
  Files          160      160              
  Lines         4599     4599              
  Branches      1043     1044       +1     
===========================================
+ Hits          4019     4023       +4     
+ Misses         318      316       -2     
+ Partials       262      260       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohitKandimalla RohitKandimalla merged commit e82d960 into develop Nov 29, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants