Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

BugFix-6194 changed the mapping of CQL to return population definitions #501

Merged

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6194
(Optional) Related Tickets:

Summary

BugFix-6194 changed the mapping of CQL to return population definitions

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner November 24, 2023 16:56
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0b44794) 4216 3926 93.12%
Head commit (38f2a12) 4218 (+2) 3928 (+2) 93.13% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#501) 12 12 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (0b44794) to head (38f2a12).
Report is 1124 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
+ Coverage    87.43%   87.45%   +0.02%     
===========================================
  Files          160      160              
  Lines         4584     4584              
  Branches      1047     1046       -1     
===========================================
+ Hits          4008     4009       +1     
  Misses         311      311              
+ Partials       265      264       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-prateekkeerthi sb-prateekkeerthi changed the title BugFIx-6194 changed the mapping of CQL to return population definitions BugFix-6194 changed the mapping of CQL to return population definitions Nov 24, 2023
@sb-prateekkeerthi sb-prateekkeerthi merged commit 0bbff47 into develop Nov 24, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants