Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

[MAT-6075] Display CQL Definition Callstack #500

Merged

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6075
(Optional) Related Tickets:

Summary

definitions used section qicore

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner November 22, 2023 16:13
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (288e366) 87.65% compared to head (7418b11) 87.47%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...editTestCase/groupCoverage/QiCoreGroupCoverage.tsx 35.71% 9 Missing ⚠️
src/api/useCqlParsingService.ts 77.77% 2 Missing ⚠️
...rc/components/editTestCase/qiCore/EditTestCase.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #500      +/-   ##
===========================================
- Coverage    87.65%   87.47%   -0.18%     
===========================================
  Files          163      164       +1     
  Lines         4665     4695      +30     
  Branches      1050     1053       +3     
===========================================
+ Hits          4089     4107      +18     
- Misses         317      329      +12     
  Partials       259      259              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Nov 22, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.23% 58.62%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (770eef9) 4302 4006 93.12%
Head commit (7418b11) 4331 (+29) 4023 (+17) 92.89% (-0.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#500) 29 17 58.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6075-definitions-used-section-qicore branch 2 times, most recently from a0286ec to c0cfa4a Compare December 1, 2023 18:22
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6075-definitions-used-section-qicore branch from c0cfa4a to 15d67a8 Compare December 5, 2023 15:15
@jkotanchik-SB jkotanchik-SB changed the title Feature/mat 6075 definitions used section qicore [MAT-6075] Display CQL Definition Callstack Dec 5, 2023
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6075-definitions-used-section-qicore branch from 15d67a8 to 7418b11 Compare December 7, 2023 15:29
@jkotanchik-SB jkotanchik-SB merged commit 0797229 into develop Dec 7, 2023
7 of 9 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-6075-definitions-used-section-qicore branch December 7, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants