Merge pull request #753 from MeasureAuthoringTool/MAT-7830_RemoveFeat…

…ureFlags MAT-7830: Remove ShiftTestCasesDates
MeasureAuthoringTool · Nov 4, 2024 · 034ecbc · 034ecbc
2 parents 9e0c036 + de99530
commit 034ecbc
Show file tree

Hide file tree

Showing 9 changed files with 69 additions and 94 deletions.
diff --git a/src/components/routes/qdm/TestCaseRoutes.test.tsx b/src/components/routes/qdm/TestCaseRoutes.test.tsx
@@ -83,7 +83,6 @@ jest.mock("@madie/madie-util", () => ({
   },
   useFeatureFlags: jest.fn().mockImplementation(() => ({
     applyDefaults: false,
-    ShiftTestCasesDates: true,
   })),
   useOktaTokens: () => ({
     getAccessToken: () => "test.jwt",

diff --git a/src/components/routes/qdm/TestCaseRoutes.tsx b/src/components/routes/qdm/TestCaseRoutes.tsx
@@ -211,14 +211,10 @@ const TestCaseRoutes = () => {
             path="/measures/:measureId/edit/test-cases/list-page/expansion"
             element={<TestCaseLandingWrapper qdm children={<Expansion />} />}
           />
-          {featureFlags?.ShiftTestCasesDates && (
-            <Route
-              path="/measures/:measureId/edit/test-cases/list-page/test-case-data"
-              element={
-                <TestCaseLandingWrapper qdm children={<TestCaseData />} />
-              }
-            />
-          )}
+          <Route
+            path="/measures/:measureId/edit/test-cases/list-page/test-case-data"
+            element={<TestCaseLandingWrapper qdm children={<TestCaseData />} />}
+          />
           <Route
             index
             element={

diff --git a/src/components/routes/qiCore/TestCaseRoutes.tsx b/src/components/routes/qiCore/TestCaseRoutes.tsx
@@ -165,17 +165,12 @@ const TestCaseRoutes = () => {
               />
             }
           />
-          {featureFlags?.ShiftTestCasesDates && (
-            <Route
-              path="/measures/:measureId/edit/test-cases/list-page/test-case-data"
-              element={
-                <TestCaseLandingWrapper
-                  qdm={false}
-                  children={<TestCaseData />}
-                />
-              }
-            />
-          )}
+          <Route
+            path="/measures/:measureId/edit/test-cases/list-page/test-case-data"
+            element={
+              <TestCaseLandingWrapper qdm={false} children={<TestCaseData />} />
+            }
+          />
         </Route>
 
         <Route

diff --git a/src/components/testCaseLanding/common/TestCaseListSideBarNav.test.tsx b/src/components/testCaseLanding/common/TestCaseListSideBarNav.test.tsx
@@ -65,7 +65,7 @@ describe("TestCase component", () => {
     );
 
     expect(screen.getByRole("navigation")).toBeInTheDocument();
-    expect(screen.getAllByRole("tab").length).toEqual(2);
+    expect(screen.getAllByRole("tab").length).toEqual(3);
     const activeLink = screen.getByRole("tab", {
       name: "Population Criteria 2",
     });

diff --git a/src/components/testCaseLanding/common/TestCaseListSideBarNav.tsx b/src/components/testCaseLanding/common/TestCaseListSideBarNav.tsx
@@ -24,8 +24,7 @@ const TestCaseListSideBarNav = ({
   qdm,
 }: TestCaseListSideBarNavProps) => {
   const featureFlags = useFeatureFlags();
-  const showConfigurationSection =
-    (!qdm && featureFlags?.ShiftTestCasesDates) || qdm;
+
   let navigate = useNavigate();
   const { measureId, criteriaId } = useParams<{
     measureId: string;
@@ -96,68 +95,63 @@ const TestCaseListSideBarNav = ({
             )}
           </Tabs>
         )}
+        <>
+          <div className="nav-collapse-container">
+            <button
+              className="nav-collapser-title"
+              onClick={() => {
+                setShowConfigTabs(!showConfigTabs);
+              }}
+              data-testid="qdm-nav-collapser"
+              id="qdm-nav-collapser"
+              tw="px-2"
+            >
+              Configuration
+              <span className="tab-dropdown">
+                {showConfigTabs ? <ExpandLessIcon /> : <ExpandMoreIcon />}
+              </span>
+            </button>
+          </div>
 
-        {showConfigurationSection && (
-          <>
-            <div className="nav-collapse-container">
-              <button
-                className="nav-collapser-title"
-                onClick={() => {
-                  setShowConfigTabs(!showConfigTabs);
-                }}
-                data-testid="qdm-nav-collapser"
-                id="qdm-nav-collapser"
-                tw="px-2"
-              >
-                Configuration
-                <span className="tab-dropdown">
-                  {showConfigTabs ? <ExpandLessIcon /> : <ExpandMoreIcon />}
-                </span>
-              </button>
-            </div>
-
-            {showConfigTabs && (
-              <Tabs
+          {showConfigTabs && (
+            <Tabs
+              type="C"
+              size="standard"
+              orientation="vertical"
+              onChange={handleChange}
+              value={endRoute}
+            >
+              {qdm && (
+                <Tab
+                  label="SDE"
+                  value="sde"
+                  data-testid="nav-link-sde"
+                  type="C"
+                  orientation="vertical"
+                  onChange={handleChange}
+                />
+              )}
+              {qdm && (
+                <Tab
+                  label="Expansion"
+                  value="expansion"
+                  data-testid="nav-link-expansion"
+                  type="C"
+                  orientation="vertical"
+                  onChange={handleChange}
+                />
+              )}
+              <Tab
+                label="Test Case Data"
+                value="test-case-data"
+                data-testid="test-case-data"
                 type="C"
-                size="standard"
                 orientation="vertical"
                 onChange={handleChange}
-                value={endRoute}
-              >
-                {qdm && (
-                  <Tab
-                    label="SDE"
-                    value="sde"
-                    data-testid="nav-link-sde"
-                    type="C"
-                    orientation="vertical"
-                    onChange={handleChange}
-                  />
-                )}
-                {qdm && (
-                  <Tab
-                    label="Expansion"
-                    value="expansion"
-                    data-testid="nav-link-expansion"
-                    type="C"
-                    orientation="vertical"
-                    onChange={handleChange}
-                  />
-                )}
-                {featureFlags?.ShiftTestCasesDates && (
-                  <Tab
-                    label="Test Case Data"
-                    value="test-case-data"
-                    data-testid="test-case-data"
-                    type="C"
-                    orientation="vertical"
-                    onChange={handleChange}
-                  />
-                )}
-              </Tabs>
-            )}
-          </>
-        )}
+              />
+            </Tabs>
+          )}
+        </>
       </Nav>
     </OuterWrapper>
   );

diff --git a/src/components/testCaseLanding/common/TestCaseTable/TestCaseTable.test.tsx b/src/components/testCaseLanding/common/TestCaseTable/TestCaseTable.test.tsx
@@ -82,7 +82,6 @@ let mockApplyDefaults = false;
 jest.mock("@madie/madie-util", () => ({
   useFeatureFlags: jest.fn().mockImplementation(() => ({
     applyDefaults: mockApplyDefaults,
-    ShiftTestCasesDates: true,
     TestCaseID: false,
   })),
 }));
@@ -345,7 +344,6 @@ describe("TestCase component", () => {
     const exportTestCase = jest.fn();
     const onCloneTestCase = jest.fn();
     (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({
-      ShiftTestCasesDates: true,
       TestCaseID: false,
     }));
 

diff --git a/src/components/testCaseLanding/common/TestCaseTable/TestCaseTablePopover.tsx b/src/components/testCaseLanding/common/TestCaseTable/TestCaseTablePopover.tsx
@@ -204,7 +204,7 @@ const TestCaseTablePopover = (props: TestCaseTablePopoverProps) => {
             </>
           )}
 
-          {canEdit && featureFlags?.ShiftTestCasesDates && (
+          {canEdit && (
             <button
               id={`shift-dates-btn-${selectedTestCase?.id}`}
               aria-label={`shift-dates-${selectedTestCase?.title}`}

diff --git a/src/components/testCaseLanding/qdm/TestCaseList.test.tsx b/src/components/testCaseLanding/qdm/TestCaseList.test.tsx
@@ -3280,9 +3280,7 @@ describe("TestCaseList component", () => {
   });
 
   it("should render shift test case dates dialogue on Test Case list page when shift test case dates button is clicked", async () => {
-    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({
-      ShiftTestCasesDates: true,
-    }));
+    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({}));
 
     const { getByTestId } = renderTestCaseListComponent();
     await waitFor(() => {
@@ -3301,9 +3299,7 @@ describe("TestCaseList component", () => {
 
   it("should shift test case dates successfully", async () => {
     testCases[0].title = "WhenAllGood";
-    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({
-      ShiftTestCasesDates: true,
-    }));
+    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({}));
     const responseDto: TestCase = {
       id: "1234",
       json: "date2",
@@ -3357,9 +3353,7 @@ describe("TestCaseList component", () => {
   });
 
   it("should handle shift test case dates failure", async () => {
-    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({
-      ShiftTestCasesDates: true,
-    }));
+    (useFeatureFlags as jest.Mock).mockClear().mockImplementation(() => ({}));
     const shiftTestCaseDatesApiMock = jest.fn().mockRejectedValueOnce(null);
     useTestCaseServiceMock.mockImplementationOnce(() => {
       return {

diff --git a/src/types/madie-madie-util.d.ts b/src/types/madie-madie-util.d.ts
@@ -14,7 +14,6 @@ declare module "@madie/madie-util" {
     qiCoreBonnieTestCases: boolean;
     qiCoreElementsTab: boolean;
     qdmHideJson: boolean;
-    ShiftTestCasesDates: boolean;
     TestCaseListSearch: boolean;
     TestCaseID: boolean;
   }