Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-8163 Remove Feature Flags #173

Merged
merged 4 commits into from
Feb 10, 2025
Merged

MAT-8163 Remove Feature Flags #173

merged 4 commits into from
Feb 10, 2025

Conversation

ethankaplan
Copy link
Contributor

@ethankaplan ethankaplan commented Feb 4, 2025

MADiE PR

Jira Ticket: MAT-8163
(Optional) Related Tickets:
MeasureAuthoringTool/madie-util#119
#173
MeasureAuthoringTool/madie-layout#389
MeasureAuthoringTool/madie-measure#779
MeasureAuthoringTool/madie-editor#454

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (a2b3d0e) to head (8ef0021).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
- Coverage    84.98%   84.89%   -0.09%     
===========================================
  Files           21       21              
  Lines          546      543       -3     
  Branches       113      112       -1     
===========================================
- Hits           464      461       -3     
  Misses          65       65              
  Partials        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethankaplan ethankaplan merged commit fbb172f into develop Feb 10, 2025
12 checks passed
@ethankaplan ethankaplan deleted the MAT-8163 branch February 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants