Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7925 remove margins for cql editor allotment wrapper #172

Closed

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Jan 14, 2025

MADiE PR

Jira Ticket: MAT-7925
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner January 14, 2025 21:17
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (a2b3d0e) to head (15a060c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #172   +/-   ##
========================================
  Coverage    84.98%   84.98%           
========================================
  Files           21       21           
  Lines          546      546           
  Branches       113      113           
========================================
  Hits           464      464           
  Misses          65       65           
  Partials        17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips
Copy link
Contributor

I'm unclear on weather the story reads to remove the margins, or ensure that they are added in both views.

@sb-cecilialiu
Copy link
Contributor Author

I'm unclear on weather the story reads to remove the margins, or ensure that they are added in both views.

Yeah I had to read the card a couple of times, as the card said it's related to https://jira.cms.gov/browse/MAT-7911, and also the current measure CQL has already had the margin removed, I think it's asking to remove the margin. Current measure CQL editor:
image

@sb-cecilialiu
Copy link
Contributor Author

@mcmcphillips I confirmed with Brandon that it should be the opposite, so I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants