This repository has been archived by the owner on Apr 23, 2020. It is now read-only.
Validation of all “complexNyms” #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,12 @@ import info.bliki.wiki.model.WikiModel; | |||
| private int definitionCount = 0; | |||
| private int definitionDepth = -1; // the depth is the number of sharps (#) in front of a definition, minus one (that's optimization to have only one substraction for the 0-based indexed list). So, to trigger comparisons, we need to be negative. | |||
|
|
|||
| private Vector<Word> complexNyms; // Used for hyponyms, hyperonyms, holonyms, and meronyms | |||
| private int complexDepth = 1; // Used to calculate the depth of the list (number of '*') | |||
| private boolean complexAlgoDirection; // Used for complexNym algorithm : | |||
There was a problem hiding this comment.
Préférer la documentation par /** quand les informations pourraient être incluses dans une doc externe. Les commentaires // sont à n'utiliser que pour les infos niveau programmeur, i.e. quand on a les “mains dans le cambouis”.
(c'est pas juste pour l'idée, c'est parce que la doc est réellement générée à partir des blocs /** et rien d'autre)
(j'ai corrigé ça dans mon dernier commit, faire un pull avant de corriger quoi que ce soit)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need almost kanban validation for all complex relations :
You can pull the commit n° 73f0ede to check only the relations hyponyms and meronyms.