Add new duping SSH executor #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
force-pushed
the
add/stdin-ssh-executor
branch
from
49866bc to
600379d
Compare
giffels
commented
Jan 17, 2025
There was a problem hiding this comment.
This change is not related to the SSH executor. I just noticed the typo in the filename.
giffels
requested review from
a team,
mschnepf and
RHofsaess
and removed request for
a team
mschnepf
approved these changes
Jan 17, 2025
| username: clown | ||
| client_keys: | ||
| - /opt/tardis/ssh/tardis | ||
| wrapper: /home/dorie/my_script.sh |
There was a problem hiding this comment.
I expected another location of the wrapper script, e.g., /home/clown/my_scritp.sh since that sound more like the home directory of the user clown
| username: clown | ||
| client_keys: | ||
| - /opt/tardis/ssh/tardis | ||
| wrapper: /home/dorie/my_script.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new executor to
TARDIS. The new duping ssh executor is a special solution for High Performance Compute Centers, which offer the opportunity to register so called ssh command keys (ssh key that can access the cluster without multi-factor authentication, but that is restricted to execute one single command without any additional command line arguments). The duping ssh executor executes commands passed over via standard input to a wrapper script, that takes care of the actual execution.