Update for automation checks #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfischer2781
requested review from
a team,
mschnepf and
RHofsaess
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 33 33
Lines 1108 1108
Branches 206 206
=======================================
Hits 1027 1027
Misses 59 59
Partials 22 22 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -39,7 +39,7 @@ | |||
| result = await payload() | |||
| except (asyncio.CancelledError, KeyboardInterrupt): | |||
| raise | |||
| except BaseException as e: | |||
| except BaseException as e: # noqa: B036 | |||
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
| @@ -36,7 +36,7 @@ | |||
| def _monitor_payload(self, payload): | |||
| try: | |||
| result = payload() | |||
| except BaseException as e: | |||
| except BaseException as e: # noqa: B036 | |||
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
mschnepf
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two automation related changes:
flake8-bugbearrecently added B036: "Don't exceptBaseExceptionunless you plan to re-raise it." This triggered at two points in COBalD's runners which catch all exceptions from running user-specified functions. This PR ignores both reported instances, since we do re-raise the exception eventually.merge_groupevent. This is required to run these tests when using a merge queue and ensure changes broken by other PRs are not merged.