Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes in API, etc. #29

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Track changes in API, etc. #29

merged 3 commits into from
Jan 17, 2025

Conversation

rocky
Copy link
Member

@rocky rocky commented Jan 14, 2025

Add script to check version

@@ -101,7 +101,7 @@ class TextCases(_SpacyBuiltin):
## >> TextCases[Import["ExampleData/EinsteinSzilLetter.txt"], "Person", 3][[2;;3]]
## = {L. Szilard, Joliot}

>> TextCases["Anne, Peter and Mr Johnes say hello.", "Person", 3][[2;;3]]
>> TextCases["Saul, Peter and Mr Johnes say hello.", "Person", 3][[2;;3]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PatternLite does not recognize Anne as a name!

It looks like we get a loss in qualiity too
@rocky rocky requested a review from mmatera January 16, 2025 01:57
@rocky
Copy link
Member Author

rocky commented Jan 17, 2025

Merging so I can use inside docker. Feel free to comment though.

@rocky rocky merged commit 62735cf into master Jan 17, 2025
5 checks passed
@rocky rocky deleted the track-changes branch January 17, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant