Enhancements: Find packages #21
Annotations
2 errors and 15 warnings
|
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
|
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
src/parse.rs#L385
[clippy] reported by reviewdog 🐶
<pre><code>warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> src/parse.rs:385:28
|
385 | if dependency
| ____________________________^
386 | | .name()
387 | | .and_then(|x| Some(x != "version"))
| |_______________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
385 ~ if dependency
386 + .name().map(|x| x != "version")
|
</code></pre>
Raw Output:
src/parse.rs:385:28:w:
<pre><code>warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> src/parse.rs:385:28
|
385 | if dependency
| ____________________________^
386 | | .name()
387 | | .and_then(|x| Some(x != "version"))
| |_______________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
385 ~ if dependency
386 + .name().map(|x| x != "version")
|
</code></pre>
__END__
|
|
src/parse.rs#L395
[clippy] reported by reviewdog 🐶
<pre><code>warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> src/parse.rs:395:29
|
395 | ... dependency.name_mut().and_then(|x| Some(*x = name.clone()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dependency.name_mut().map(|x| *x = name.clone())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
</code></pre>
Raw Output:
src/parse.rs:395:29:w:
<pre><code>warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> src/parse.rs:395:29
|
395 | ... dependency.name_mut().and_then(|x| Some(*x = name.clone()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dependency.name_mut().map(|x| *x = name.clone())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
</code></pre>
__END__
|
|
src/parse.rs#L395
[clippy] reported by reviewdog 🐶
<pre><code>warning: passing a unit value to a function
--> src/parse.rs:395:64
|
395 | ... dependency.name_mut().and_then(|x| Some(*x = name.clone()));
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
395 ~ dependency.name_mut().and_then(|x| {
396 + *x = name.clone();
397 + Some(())
398 ~ });
|
</code></pre>
Raw Output:
src/parse.rs:395:64:w:
<pre><code>warning: passing a unit value to a function
--> src/parse.rs:395:64
|
395 | ... dependency.name_mut().and_then(|x| Some(*x = name.clone()));
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
395 ~ dependency.name_mut().and_then(|x| {
396 + *x = name.clone();
397 + Some(())
398 ~ });
|
</code></pre>
__END__
|
|
src/main.rs#L41
[clippy] reported by reviewdog 🐶
<pre><code>warning: length comparison to zero
--> src/main.rs:41:12
|
41 | if dependency_with_versions.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dependency_with_versions.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
</code></pre>
Raw Output:
src/main.rs:41:12:w:
<pre><code>warning: length comparison to zero
--> src/main.rs:41:12
|
41 | if dependency_with_versions.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dependency_with_versions.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
</code></pre>
__END__
|
|
src/main.rs#L62
[clippy] reported by reviewdog 🐶
<pre><code>warning: this `.filter_map` can be written more simply using `.map`
--> src/main.rs:62:35
|
62 | let diagnostics: Vec<_> = dependency_with_versions
| ___________________________________^
63 | | .into_iter()
64 | | .filter_map(|dependency| {
65 | | if let Some(Some(newest_version)) = newest_packages.get(&dependency.name) {
... |
94 | | }
95 | | })
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
</code></pre>
Raw Output:
src/main.rs:62:35:w:
<pre><code>warning: this `.filter_map` can be written more simply using `.map`
--> src/main.rs:62:35
|
62 | let diagnostics: Vec<_> = dependency_with_versions
| ___________________________________^
63 | | .into_iter()
64 | | .filter_map(|dependency| {
65 | | if let Some(Some(newest_version)) = newest_packages.get(&dependency.name) {
... |
94 | | }
95 | | })
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
</code></pre>
__END__
|
|
src/main.rs#L79
[clippy] reported by reviewdog 🐶
<pre><code>warning: unneeded `return` statement
--> src/main.rs:79:33
|
79 | ... return Some(Diagnostic::new_simple(range, "✓".to_string()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
79 - return Some(Diagnostic::new_simple(range, "✓".to_string()));
79 + Some(Diagnostic::new_simple(range, "✓".to_string()))
|
</code></pre>
Raw Output:
src/main.rs:79:33:w:
<pre><code>warning: unneeded `return` statement
--> src/main.rs:79:33
|
79 | ... return Some(Diagnostic::new_simple(range, "✓".to_string()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
79 - return Some(Diagnostic::new_simple(range, "✓".to_string()));
79 + Some(Diagnostic::new_simple(range, "✓".to_string()))
|
</code></pre>
__END__
|
|
src/main.rs#L83
[clippy] reported by reviewdog 🐶
<pre><code>warning: unneeded `return` statement
--> src/main.rs:83:29
|
83 | / ... return Some(Diagnostic::new_simple(
84 | | ... range.clone(),
85 | | ... format!("{}: {newest_version}", &dependency.name),
86 | | ... ));
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
83 ~ Some(Diagnostic::new_simple(
84 + range.clone(),
85 + format!("{}: {newest_version}", &dependency.name),
86 ~ ))
|
</code></pre>
Raw Output:
src/main.rs:83:29:w:
<pre><code>warning: unneeded `return` statement
--> src/main.rs:83:29
|
83 | / ... return Some(Diagnostic::new_simple(
84 | | ... range.clone(),
85 | | ... format!("{}: {newest_version}", &dependency.name),
86 | | ... ));
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
83 ~ Some(Diagnostic::new_simple(
84 + range.clone(),
85 + format!("{}: {newest_version}", &dependency.name),
86 ~ ))
|
</code></pre>
__END__
|
|
src/main.rs#L90
[clippy] reported by reviewdog 🐶
<pre><code>warning: unneeded `return` statement
--> src/main.rs:90:21
|
90 | / return Some(Diagnostic::new_simple(
91 | | dependency.version.range(),
92 | | format!("{}: Unknown crate", &dependency.name),
93 | | ));
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
90 ~ Some(Diagnostic::new_simple(
91 + dependency.version.range(),
92 + format!("{}: Unknown crate", &dependency.name),
93 ~ ))
|
</code></pre>
Raw Output:
src/main.rs:90:21:w:
<pre><code>warning: unneeded `return` statement
--> src/main.rs:90:21
|
90 | / return Some(Diagnostic::new_simple(
91 | | dependency.version.range(),
92 | | format!("{}: Unknown crate", &dependency.name),
93 | | ));
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
90 ~ Some(Diagnostic::new_simple(
91 + dependency.version.range(),
92 + format!("{}: Unknown crate", &dependency.name),
93 ~ ))
|
</code></pre>
__END__
|
|
src/main.rs#L70
[clippy] reported by reviewdog 🐶
<pre><code>warning: using `clone` on type `Range` which implements the `Copy` trait
--> src/main.rs:70:37
|
70 | ... range.clone(),
| ^^^^^^^^^^^^^ help: try dereferencing it: `*range`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
</code></pre>
Raw Output:
src/main.rs:70:37:w:
<pre><code>warning: using `clone` on type `Range` which implements the `Copy` trait
--> src/main.rs:70:37
|
70 | ... range.clone(),
| ^^^^^^^^^^^^^ help: try dereferencing it: `*range`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
</code></pre>
__END__
|
|
src/main.rs#L84
[clippy] reported by reviewdog 🐶
<pre><code>warning: using `clone` on type `Range` which implements the `Copy` trait
--> src/main.rs:84:33
|
84 | ... range.clone(),
| ^^^^^^^^^^^^^ help: try dereferencing it: `*range`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
</code></pre>
Raw Output:
src/main.rs:84:33:w:
<pre><code>warning: using `clone` on type `Range` which implements the `Copy` trait
--> src/main.rs:84:33
|
84 | ... range.clone(),
| ^^^^^^^^^^^^^ help: try dereferencing it: `*range`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
</code></pre>
__END__
|
The logs for this run have expired and are no longer available.
Loading