Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug reading large random seeds #319

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix bug reading large random seeds #319

merged 1 commit into from
Dec 12, 2024

Conversation

drbergman
Copy link
Collaborator

stoi is currently used to parse random seed strings, but it does not work on all unsigned ints. So, use unsigned int and stoul instead to parse the random seed

@drbergman drbergman requested a review from rheiland November 7, 2024 21:26
@drbergman drbergman added the bug label Dec 5, 2024
@MathCancer MathCancer merged commit 7ac6d59 into MathCancer:development Dec 12, 2024
208 checks passed
@drbergman drbergman deleted the fix-read-unsigned_int-random-seeds branch December 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rheiland rheiland Awaiting requested review from rheiland

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drbergman @MathCancer