Fix deserialisation of responses #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e that properties with private setters have their values set, too.
|
I think this is actually the same issue as #4, so this PR should help you resolve that one, too. |
|
... and probably this solves #1 as well :) |
|
This is great news! I noticed that the build failed. Is it easily fixable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Resultproperty of theCommandResponse<T>object was never being assigned in my case.I tracked it down to
Resulthaving a private setter, which Newtonsoft.Json apparently never tries to assign values to (at least in the most recent versions).You can workaround this by creating a custom
ContractResolver.This PR implements that behavior, and allows for the creators of the
CommandResponseFactoryto pass a customer serializer if they so desire. I also made theMessageContractResolveryou ship public, as I for example wanted to re-use that one in my code (I manually serialize theCommandRequeststo the wire).I added a unit test which can act as a non-regression test for this fix.