Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join path #29

Closed
wants to merge 3 commits into from
Closed

join path #29

wants to merge 3 commits into from

Conversation

LiuQiE
Copy link
Contributor

@LiuQiE LiuQiE commented Jul 17, 2017 •
edited by vkosuri
Loading

It changes the way to join two paths.

For example:

BEFORE:

>>> os.path.join('/home/ute/ta_kiss_files/example/', '/ram')
'/ram'

AFTER:

>>> os.path.join('/home/ute/ta_kiss_files/example/', 'ram')
'/home/ute/ta_kiss_files/example/ram'

Closes: #28

@LiuQiE
Copy link
Contributor Author

LiuQiE commented Jul 19, 2017

Can anyone merge the PR as soon as possible? I need to put it in our pip sever now. Thank you!

@bulkan bulkan closed this Jul 19, 2017
@bulkan
Copy link
Collaborator

bulkan commented Jul 19, 2017

@LiuQiE can you please re-submit the PR in which there isn't a commit that deletes utils.py and another that re-adds it ?

@LiuQiE
Copy link
Contributor Author

LiuQiE commented Jul 19, 2017

Yes, I submitted a new one just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkosuri vkosuri vkosuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiuQiE @bulkan @vkosuri