more MDEV-35429 my_snprintf fixes for 10.5+ #3749
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadoxV5
commented
Jan 10, 2025
| block_info.block_len+ (uint) (block_info.filepos-pos), | ||
| llstr(pos,llbuff)); | ||
| "Found block with impossible length %lu at %s; Skipped", | ||
| block_info.block_len + (unsigned long) (block_info.filepos-pos), |
There was a problem hiding this comment.
MI_BLOCK_INFO::filepos and local var pos are both my_off_t which can be as large as unsigned long long, yet the old code casted to uint.
Here I cast to unsigned long to match MI_BLOCK_INFO::block_len (and #3748 and its surrounding code too).
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Jan 10, 2025
* MariaDB#3746 * MariaDB#3747 * MariaDB#3748 * MariaDB#3749 This commit should not be merged, but skipping it before the above PRs merge to the `main` branch will brick CIs on `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
os0file.cc: usePRIu64overllumi_check.c: in impossible block length warning-WformatChecks onmy_vsnprintfand Users #3360 too?).How can this PR be tested? (& Release Notes)
os0file.cc: N/A: This only impacts platforms whoselong longislonger than 64bits.mi_check.c: IIRC,%uand%luare different on Linux.PR quality check
This is a new feature or a refactoring, and the PR is based against themainbranch.