MDEV-35818: Fix replace_binlog_file info message
#3746
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ATTRIBUITE_FORMAT` from #3360 uncovers issues on `my_snprintf` uses. This commit fixes the one in `Binlog_commit_by_rotate::` `replace_binlog_file()` about “required size too big”. All I found is that it’s not present in 11.4 (after I prepared previous batches for all maintained branches), for GitHub blame can’t process a file with over 10K lines.
ParadoxV5
commented
Jan 10, 2025
| required_size, m_cache_data->file_reserved_bytes()); | ||
| "Required %zu bytes but only %lu bytes reserved.", | ||
| required_size, | ||
| (unsigned long) m_cache_data->file_reserved_bytes()); |
There was a problem hiding this comment.
binlog_cache_data::file_reserved_bytes() is an uint32, which doesn’t necessarily match PRIu32’s uint32_t, so I’m up-casting for now.
MDEV-35460
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Jan 10, 2025
* MariaDB#3746 * MariaDB#3747 * MariaDB#3748 * MariaDB#3749 This commit should not be merged, but skipping it before the above PRs merge to the `main` branch will brick CIs on `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATTRIBUITE_FORMATfrom #3360 uncovers issues onmy_snprintfuses.This commit fixes the one in
Binlog_commit_by_rotate::replace_binlog_file()about “required size too big”.All I found is that it’s not present in 11.4 (after I prepared previous batches for all maintained branches), for GitHub blame can’t process a file with over 10K lines.
Release Notes
But 11.7 wasn’t Generally Available yet?
How can this PR be tested?
I suppose we can trigger this issue by running the
simulate_required_size_too_bigtest (wherever it is) in 32-bit Linux.PR quality check
This is a new feature or a refactoring, and the PR is based against themainbranch.