Rename constants to use capital letters consistently #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvicentiu
force-pushed
the
rename_constants
branch
from
66f3826 to
3dbe393
Compare
|
This PR is done, but will be merged after the previous refactoring ones are merged. |
cvicentiu
force-pushed
the
rename_constants
branch
10 times, most recently
from
cc261ab to
56ddb71
Compare
cvicentiu
force-pushed
the
rename_constants
branch
from
19e99e9 to
8d1c0ed
Compare
cvicentiu
force-pushed
the
rename_constants
branch
3 times, most recently
from
6088cd7 to
c4c2926
Compare
cvicentiu
force-pushed
the
rename_constants
branch
2 times, most recently
from
360698b to
9ec1ba2
Compare
|
Ready for review. |
cvicentiu
force-pushed
the
rename_constants
branch
3 times, most recently
from
5cb900b to
138ef20
Compare
all_platforms -> ALL_PLATFORMS branches_main -> BRANCHES_MAIN builders_autobake -> BUILDERS_AUTOBAKE builders_big -> BUILDERS_BIG builders_dockerlibrary -> BUILDERS_DOCKERLIBRARY builders_eco -> BUILDERS_ECO builders_galera -> BUILDERS_GALERA builders_install -> BUILDERS_INSTALL builders_s3 -> BUILDERS_S3 builders_upgrade -> BUILDERS_UPGRADE builders_wordpress -> BUILDERS_WORDPRESS github_status_builders -> GITHUB_STATUS_BUILDERS release_branches -> RELEASE_BRANCHES savedPackageBranches -> SAVED_PACKAGE_BRANCHES savedPackageBranches (master-galera) -> SAVED_PACKAGE_BRANCHES_GALERA supportedPlatforms -> SUPPORTED_PLATFORMS os_info -> OS_INFO (yes, it is read from a yaml file, but acts as a constant)
cvicentiu
force-pushed
the
rename_constants
branch
from
138ef20 to
3f97f5c
Compare
|
Rebased on top of latest dev. Some black linter enforced cleanups as well. |
RazvanLiviuVarzaru
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to refactor constants.py to declare constants as capital letters.