Refactor utils.py #637
Merged
Refactor utils.py #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvicentiu
force-pushed
the
refactor-3
branch
2 times, most recently
from
04671c9 to
1c53f57
Compare
cvicentiu
force-pushed
the
refactor-3
branch
from
1c53f57 to
d78def1
Compare
fauust
reviewed
Nov 26, 2024
fauust
reviewed
Nov 26, 2024
cvicentiu
force-pushed
the
refactor-3
branch
2 times, most recently
from
7c18870 to
7a6bfb2
Compare
cvicentiu
force-pushed
the
refactor-3
branch
4 times, most recently
from
592abdd to
41590c3
Compare
1. Introduce typehints 2. Include what you use.
The sorting key sorts in the following priority order: 1. First release branches 2. Next branches that create packages 3. Finally, first come, first serve. This sort key has the added benefit of ensuring that for equal priority build requests, the one that was first in queue is the first picked up. Buildbot documentation does not make any guarantees that the initial requests list is sorted by submit time.
RazvanLiviuVarzaru
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
The branch prioritisation logic should be double checked.