SLES/OpenSUSE - build 15.5 and then install/upgrade test to later #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok, but I suggest pinging Elena and Daniel to raise awareness for the Q1 2025 release. |
| if "sles-1505" in builderName or "opensuse-1505" in builderName: | ||
| builders.append(b.replace("1505", "1506")) | ||
| break | ||
| return builders |
There was a problem hiding this comment.
Nice touch here, rather than returning an empty list if the parent builder doesn't have any install / upgrade builders defined.
RazvanLiviuVarzaru
force-pushed
the
dev
branch
from
d7eb898 to
4be5d7c
Compare
This keep our packages list smaller, less building, and works for 15.5 and 15.6 Factor the generation of lists together as what should be identical implementation. There should be only one match in the list.
grooverdan
force-pushed
the
sles_opensuse_cross_upgrade
branch
from
652ead5 to
8c5f1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keep our packages list smaller, less building, and works for 15.5 and 15.6
Factor the generation of lists together as what should be identical implementation. There should be only one match in the list.
Template selection
Please go the the
Previewtab and select the appropriate sub-template: