-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we use OSM Americana? #13
base: trunk
Are you sure you want to change the base?
Conversation
I'm cool with it. I think the mask looks very nice, too. It's a bit unfortunate that Americana uses similar circles for town labels, but using purple for "Unknown/Other" helps alleviate that. It's a bit sad to give up the delineations between different counties. I wonder if we could re-introduce that in a way that visually meshes with the mask. @mhpob, if you dig these changes I say we merge |
I improved boundary line popups in e0bff3a, if we end up rendering boundaries in this PR I'll want to merge that in. |
It looks good, esp. with the mask. There are lots of reds and greens; I'm not colorblind so I can't immediately tell, but may this cause issues? Probably beyond the scope of this PR |
I can see what I can do to tweak the boundaries in Americana or just bring back the boundaries from overpass. I just didn't want plain black boundaries. I'll see what i come up with and share an update |
Yeah. Regarding the colors, having shapes for each type and at all zoom levels would help. |
Updated with boundaries, check it out: https://overpass-ultra.us/#run&query=url:https://raw.githubusercontent.com/MapRVA/maprva.org/d8c13b31eb73fa6e8ea10bfd8adb9d7b296b77b6/_includes/ultra-maps/surveillance.ultra TBH, the more I use it.. the less I like it 😬 The high contrast of the features in Americana itself distract from the features we're trying to highlight IMO. |
Just an idea, what do y'all think @mhpob @jacobwhall?
Also added a mask to better highlight that this is a map of just the greater Richmond area.