feat: add pino-caller support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CptSchnitz
requested changes
Sep 18, 2024
src/index.ts
Outdated
Comment on lines
25
to
26
| const loggerWithCaller = pinoCaller(logger); | ||
| return options?.pinoCaller === true ? loggerWithCaller : logger; |
There was a problem hiding this comment.
Suggested change
| const loggerWithCaller = pinoCaller(logger); | |
| return options?.pinoCaller === true ? loggerWithCaller : logger; | |
| return options?.pinoCaller === true ? pinoCaller(logger) : logger; |
i think running less code > clarity in this case.
what do you think?
Added |
CptSchnitz
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further information:
Add support of pino-caller.
pino-caller adds the call site of each log message to the log output