Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Update factory_bot to fix the build #118

Closed
wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 10, 2024

It is building with activesupport 7.2
FactoryBot 5.1 does not work with this version
FactoryBot 6.5 is more compatible

We can either:

  1. peg to activesupport 7.0
  2. allow activesupport 7.2 and require newer factorybot and newer ruby

It is building with activesupport 7.2
FactoryBot 5.1 does not work with this version
FactoryBot 6.5 is more compatible
@Fryguy
Copy link
Member

Fryguy commented Sep 10, 2024

We don't specifically depend on active support here, and it's just coming in from more core.

@Fryguy Fryguy self-assigned this Sep 10, 2024
@Fryguy
Copy link
Member

Fryguy commented Sep 10, 2024

I'm good with dropping the old Rubies here - not sure if this will require a major version release or not. @agrare Thoughts?

@miq-bot
Copy link
Member

miq-bot commented Sep 10, 2024

Checked commit kbrock@97c676f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@agrare
Copy link
Member

agrare commented Sep 10, 2024

I would definitely do a minor bump for dropping those rubies

@Fryguy
Copy link
Member

Fryguy commented Sep 10, 2024

Closing in favor of archiving this repository.

@Fryguy Fryguy closed this Sep 10, 2024
@kbrock kbrock deleted the factorybot-master branch September 10, 2024 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants