Clean hotfix directory before patching the srpm contents #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jrafanie
force-pushed
the
clean_hotfix_directory
branch
from
2f9eebd to
80eb3c1
Compare
agrare
reviewed
Jan 3, 2025
| @@ -64,6 +65,11 @@ def update_spec | |||
| File.write(rpm_spec, spec_text) | |||
| end | |||
|
|
|||
| def clean_hotfix_directory | |||
| files = Dir.glob("*").reject {|path| path.end_with?("src.rpm") } | |||
There was a problem hiding this comment.
Minor
Suggested change
| files = Dir.glob("*").reject {|path| path.end_with?("src.rpm") } | |
| files = Dir.glob("*").reject { |path| path.end_with?("src.rpm") } |
There was a problem hiding this comment.
If we're not using the glob part of Dir.glob would Dir.children(".") work?
There was a problem hiding this comment.
Even better:
Suggested change
| files = Dir.glob("*").reject {|path| path.end_with?("src.rpm") } | |
| files = Dir.glob("*[!.src.rpm]") |
There was a problem hiding this comment.
haha, I had glob negation at first but thought this looked more obvious considering performance isn't going to matter on a handful of file. I can change it if you also liked it 😉
There was a problem hiding this comment.
I personally think it reads better :D
There was a problem hiding this comment.
haha, ship it... just verifying it
For those of us who don't patch the srpm contents correctly the first or even second time, we should do something like make clean before we extract the srpm, patch things, and attempt to rpmbuild.
jrafanie
force-pushed
the
clean_hotfix_directory
branch
from
80eb3c1 to
8894d25
Compare
Fryguy
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those of us who don't patch the srpm contents correctly the first or
even second time, we should do something like make clean before we extract
the srpm, patch things, and attempt to rpmbuild.