Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right foreign_key for Job#job_template #22

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 9, 2024

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2024

Checked commit agrare@61cc8b3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

app/models/manageiq/providers/awx/automation_manager/job.rb

@Fryguy
Copy link
Member

Fryguy commented Jan 10, 2024

I wonder if this will solve https://github.com/orgs/manageiq/discussions/22794

@agrare
Copy link
Member Author

agrare commented Jan 11, 2024

I wonder if this will solve https://github.com/orgs/manageiq/discussions/22794

Interesting, I doubt it since someone said it was working in najdorf and this bug has been there for a long time. I'll look at that in a little bit though.

@Fryguy Fryguy closed this Jan 11, 2024
@Fryguy Fryguy reopened this Jan 11, 2024
@Fryguy Fryguy self-assigned this Jan 11, 2024
@Fryguy Fryguy merged commit 155894b into ManageIQ:master Jan 11, 2024
3 of 4 checks passed
@Fryguy
Copy link
Member

Fryguy commented Jan 11, 2024

Backported to quinteros in commit 22bcfe1.

commit 22bcfe1d327921e9fff2d897c8e8bc7caffd1d17
Author: Jason Frey <[email protected]>
Date:   Thu Jan 11 15:46:41 2024 -0500

    Merge pull request #22 from agrare/use_correct_foreign_key_job_templates
    
    Use the right foreign_key for Job#job_template
    
    (cherry picked from commit 155894ba69e0597ad56b85960fda6cdc0b746ae0)

Fryguy added a commit that referenced this pull request Jan 11, 2024
Use the right foreign_key for Job#job_template

(cherry picked from commit 155894b)
@agrare agrare deleted the use_correct_foreign_key_job_templates branch January 11, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quinteros/backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants