Allow rails 7 gems in gemspec #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
allow_rails_7
branch
2 times, most recently
from
f514b76 to
24f59e9
Compare
jrafanie
force-pushed
the
allow_rails_7
branch
from
24f59e9 to
e0a10cc
Compare
|
Note, we only use activesupport for Time.current and symbolize_keys. |
bdunne
reviewed
Jan 18, 2024
| @@ -12,13 +12,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| ruby-version: | |||
| - '2.5' | |||
| - '2.6' | |||
| - '2.7' | |||
| - '3.0' | |||
There was a problem hiding this comment.
yeah, I was debating it in all my prs and didn't in some. I can add it. I should probably circle around and do it for all of them that are standalone.
There was a problem hiding this comment.
good call, tests are broken on ruby 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rails 7 gems in gemspec