Script to generate Kafka keystores for SSL #955
Conversation
| fi | ||
|
|
||
| # Generate truststore containing CA | ||
| keytool -keystore ./kafka.truststore.jks \ |
There was a problem hiding this comment.
keytool comes with any Java distribution. I guess this means that the script assumes the user has Java on their system. Would this be an issue?
| if [ -z "$KEYSTORE_PASS" ]; then | ||
| echo "Please provide a keystore password in KEYSTORE_PASS" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
For security reasons we may want to read the password from STDIN.
There was a problem hiding this comment.
updated the script to now use read
nasark
force-pushed
the
keystore_gen_script
branch
from
d0c75fb to
7b8780a
Compare
|
Is it possible to go the other direction leave generation of the certificates in the current script and have an entrypoint script on the kafka container that creates a keystore and adds those certs to it? |
|
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
Would have preferred this being in appliance_console{_cli} but if that does not create certificates, then that request is out of scope. Did we want the bot to close this? |
|
Checked commits nasark/manageiq-pods@504c330~...7b8780a with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
|
This can be closed as we are no longer moving forward with Bitnami and this will not be needed for Strimzi |
root.crtcreated in cert_generator.rb) and keystore password determined by userNeeded for:
@miq-bot assign @bdunne
@miq-bot add_reviewer @Fryguy
@miq-bot add_label enhancement