Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or update unique volume mount #1008

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

nasark
Copy link
Member

@nasark nasark commented Nov 2, 2023

In kubernetes it is not possible to mount multiple volumes with the same mount path i.e. mount volume paths must be unique. Therefore added the edge case where if another volume is to be added that has the same mount path as an existing volume, the old volume is replaced

Needed for:

@miq-bot add_label enhancement
@miq-bot assign @bdunne

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2023

Checked commit nasark@560986c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne merged commit 880f39a into ManageIQ:master Nov 6, 2023
@Fryguy
Copy link
Member

Fryguy commented Nov 8, 2023

Backported to quinteros in commit 8402f01.

commit 8402f0188930d4330e439e6da3d21e9c29296979
Author: Brandon Dunne <[email protected]>
Date:   Mon Nov 6 09:56:51 2023 -0500

    Merge pull request #1008 from nasark/add_update_unique_vol_mount
    
    Add or update unique volume mount
    
    (cherry picked from commit 880f39ac19692166b101e93e63e90344e6ff6995)

Fryguy pushed a commit that referenced this pull request Nov 8, 2023
Add or update unique volume mount

(cherry picked from commit 880f39a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants