-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to "Configure Network" or "Set Hostname" #1784
base: master
Are you sure you want to change the base?
Conversation
These are replaced by system tools in EL9 Based on: ManageIQ/manageiq-appliance_console#238
Checked commit bdunne@0ac300c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
the configuration. | ||
|
||
6. For **Should this appliance run as a standalone database | ||
5. For **Should this appliance run as a standalone database | ||
server?**, select `y`. Selecting this option configures this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select y
should be:
Select y.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there more of these? It feels like they should be in a different PR since it's unrelated to the changes made here.
|
||
5. Select the database disk. {{ site.data.product.title_short }} then activates | ||
4. Select the database disk. {{ site.data.product.title_short }} then activates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Select database disk.
|
||
3. Configure this appliance to use the encryption key from the | ||
2. Configure this appliance to use the encryption key from the | ||
primary database-only appliance: | ||
|
||
1. For **Encryption Key**, select **Fetch key from remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch key from remote should be in **.
This should be select Fetch key from remote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qahmed1998 I think all of these changes are "wrong" to start with. I'm wondering if we should have these changes done afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore my comment for fetch key from remote. This is fine.
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
These are replaced by system tools in EL9
Based on: ManageIQ/manageiq-appliance_console#238