Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to "Configure Network" or "Set Hostname" #1784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Mar 13, 2024

These are replaced by system tools in EL9
Based on: ManageIQ/manageiq-appliance_console#238

@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2024

Checked commit bdunne@0ac300c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy self-assigned this Mar 13, 2024
the configuration.

6. For **Should this appliance run as a standalone database
5. For **Should this appliance run as a standalone database
server?**, select `y`. Selecting this option configures this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select y should be:

Select y.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more of these? It feels like they should be in a different PR since it's unrelated to the changes made here.


5. Select the database disk. {{ site.data.product.title_short }} then activates
4. Select the database disk. {{ site.data.product.title_short }} then activates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Select database disk.


3. Configure this appliance to use the encryption key from the
2. Configure this appliance to use the encryption key from the
primary database-only appliance:

1. For **Encryption Key**, select **Fetch key from remote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch key from remote should be in **.

This should be select Fetch key from remote.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qahmed1998 I think all of these changes are "wrong" to start with. I'm wondering if we should have these changes done afterwards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comment for fetch key from remote. This is fine.

@miq-bot miq-bot added the stale label Aug 19, 2024
@miq-bot
Copy link
Member

miq-bot commented Aug 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Nov 25, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants