Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2v documentation #1681

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

jrafanie
Copy link
Member

This was removed as part of ManageIQ/manageiq-api#1085
and the large project to remove v2v:
ManageIQ/manageiq#21379

This was removed on master and najdorf but still remains on morphy. I don't know if we maintain old documentation here but opened this to discuss it.

This was removed as part of ManageIQ/manageiq-api#1085
and the large project to remove v2v:
ManageIQ/manageiq#21379
@Fryguy
Copy link
Member

Fryguy commented Jun 27, 2022

I don't know if we maintain old documentation here but opened this to discuss it.

We have branches for the old code, so we can delete on master and also backport to najdorf.

@Fryguy
Copy link
Member

Fryguy commented Jun 27, 2022

@jrafanie Be sure to also remove from the left side menu, which is, annoyingly, here: https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml

@jrafanie
Copy link
Member Author

I don't know if we maintain old documentation here but opened this to discuss it.

We have branches for the old code, so we can delete on master and also backport to najdorf.

Right, but this is documentation, not code. Due to lack of resources, I can see it makes sense to only maintain what's supported going forward and others can checkout the doc for their branch if they want to use an older version.

@jrafanie
Copy link
Member Author

@jrafanie Be sure to also remove from the left side menu, which is, annoyingly, here: https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml

Will do.

jrafanie added a commit to jrafanie/manageiq.org that referenced this pull request Jun 27, 2022
This was removed as part of ManageIQ/manageiq-api#1085
and the large project to remove v2v:
ManageIQ/manageiq#21379

Related to github.com/ManageIQ/manageiq-documentation/pull/1681
@jrafanie
Copy link
Member Author

@jrafanie Be sure to also remove from the left side menu, which is, annoyingly, here: https://github.com/ManageIQ/manageiq.org/blob/master/site/_data/menus/api_menu.yml

Will do.

I don't know why it's here and there, but here's the other part: ManageIQ/manageiq.org#1103

@miq-bot
Copy link
Member

miq-bot commented Jun 27, 2022

Checked commit jrafanie@e35e84b with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy
Copy link
Member

Fryguy commented Jun 27, 2022

I don't know why it's here and there

🤷 ManageIQ/manageiq.org#814

@Fryguy Fryguy merged commit 1461fe7 into ManageIQ:master Jun 27, 2022
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Jun 27, 2022
@jrafanie jrafanie deleted the remove_v2v_documentation branch June 27, 2022 17:36
@Rajitha20H
Copy link
Contributor

@jrafanie @Fryguy , Do these changes apply to MCM as well? Because since we removed the files, the reference to these files in summary.md in MCM is holding up the build. If they are not needed in MCM, we can remove the references.

@jrafanie
Copy link
Member Author

@jrafanie @Fryguy , Do these changes apply to MCM as well?

2.3 IM no. ManageIQ/manageiq-api#1085 wasn't in morphy.
3.4 IA yes. It was in najdorf.

Fryguy added a commit that referenced this pull request Aug 18, 2022
Remove v2v documentation

(cherry picked from commit 1461fe7)
@Fryguy
Copy link
Member

Fryguy commented Aug 18, 2022

Backported to najdorf in commit 70d540a.

commit 70d540ae02b220cbfd35894161721844d60bd559
Author: Jason Frey <[email protected]>
Date:   Mon Jun 27 13:11:32 2022 -0400

    Merge pull request #1681 from jrafanie/remove_v2v_documentation
    
    Remove v2v documentation
    
    (cherry picked from commit 1461fe7717d4fd44c27e84f25f01bd960bb2b7e3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants