Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Update template upload for rhevm, name database disk #8936

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

mshriver
Copy link
Member

@mshriver mshriver commented Jun 11, 2019

Depends on wrapanapi: RedHatQE/wrapanapi#390

Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izapolsk izapolsk changed the title [WIPTEST] Update template upload for rhevm, name database disk [1LP][WIPTEST] Update template upload for rhevm, name database disk Jun 11, 2019
size=rhevm_specs.disk_size,
interface=rhevm_specs.disk_interface,
format=rhevm_specs.disk_format)
size=rhevm_specs.get('disk_size', 5000000000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we are defaulting to this value, do you think it would benefit us in any way to have that as a parameter on add_disk_to_vm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this case, since this is just a template upload method.

@kedark3
Copy link
Contributor

kedark3 commented Jun 11, 2019

LGTM, only one comment.

@mshriver mshriver changed the title [1LP][WIPTEST] Update template upload for rhevm, name database disk [1LP][RFR] Update template upload for rhevm, name database disk Jun 25, 2019
@mshriver mshriver force-pushed the rhevm-thick-deploy-args branch from eb759ee to 98bec32 Compare June 25, 2019 14:38
@jawatts jawatts merged commit 497d333 into ManageIQ:master Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants