Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ move chart to subdir charts #389

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

DrPsychick
Copy link

@DrPsychick DrPsychick commented Dec 24, 2024

Why?

  • To avoid an issue with chart-testing using chart-dirs=., moved the chart to subdir ./charts and adjusted the workflows etc. accordingly.
  • Configure dependabot for GitHub actions
  • removed unnecessary symlink to ci/helm-lint-values.yaml (removes warnings)

see chart-dirs='.' has issues: sapcc/helm-charts#7480

@fastlorenzo
Copy link
Collaborator

oh boy, moving the charts folder will require some testing 😄 thanks for the first PR, I'll try it out

@DrPsychick
Copy link
Author

To be fair, the part with separating the workflow jobs could be completely reverted to reduce scope. I'm not sure if it is needed.

As for the charts directory, I had some issues with running ct lint and I stumbled over the related issue and since the default chart-dirs is charts (besides, it makes the workflow a bit simpler using checkout with defaults), I think it cannot hurt to do this change.
At latest when mailu-charts contains more than one chart it would be beneficial anyway, IMHO.

I guess mostly the publishing part needs another review/check if it is still working.

@DrPsychick DrPsychick changed the title feat: ✨ github actions cleanup/improvements feat: ✨ move chart to subdir charts Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants