Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(digest): add redirect link to bitcoin explorer #346

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented May 28, 2024

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 5:37am

@FrederLu
Copy link

https://ckb-explorer-frontend-in-magickbase-repo-iprxt1sye-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6
image
There will be overlap between new icons and data on the RGB++ Digest pop-up window.

@Keith-CY
Copy link
Member

Keith-CY commented Jun 4, 2024

ckb-explorer-frontend-in-magickbase-repo-iprxt1sye-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6 image There will be overlap between new icons and data on the RGB++ Digest pop-up window.

Any update on this conversation @Daryl-L

@Daryl-L
Copy link
Author

Daryl-L commented Jun 5, 2024

ckb-explorer-frontend-in-magickbase-repo-iprxt1sye-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6 image There will be overlap between new icons and data on the RGB++ Digest pop-up window.

Any update on this conversation @Daryl-L

Pushed, just forgot to push the commit

@FrederLu
Copy link

FrederLu commented Jun 5, 2024

ckb-explorer-frontend-in-magickbase-repo-iprxt1sye-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6 image There will be overlap between new icons and data on the RGB++ Digest pop-up window.

Any update on this conversation @Daryl-L

Pushed, just forgot to push the commit

https://ckb-explorer-frontend-in-magickbase-repo-nu9q7lqqs-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

image

The preview address has been updated and there should be new submissions, but the problem still exists. @Daryl-L

@Daryl-L
Copy link
Author

Daryl-L commented Jun 5, 2024

/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

Preview link was updated by vercel, it is ok from the latest preview link

@FrederLu
Copy link

FrederLu commented Jun 5, 2024

/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

Preview link was updated by vercel, it is ok from the latest preview link

2024-06-05.16.08.35.mov

The preview address is new,on a 13.3-inch (2560 × 1600) PC, the overlap is at 100%, but it is normal to adjust it to 90%.

@Daryl-L
Copy link
Author

Daryl-L commented Jun 5, 2024

/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

Preview link was updated by vercel, it is ok from the latest preview link

2024-06-05.16.08.35.mov
The preview address is new,on a 13.3-inch (2560 × 1600) PC, the overlap is at 100%, but it is normal to adjust it to 90%.

image
Do you mean this size of the screen?

@FrederLu
Copy link

FrederLu commented Jun 5, 2024

/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

Preview link was updated by vercel, it is ok from the latest preview link

2024-06-05.16.08.35.mov
The preview address is new,on a 13.3-inch (2560 × 1600) PC, the overlap is at 100%, but it is normal to adjust it to 90%.

image Do you mean this size of the screen?

Your screen size is relatively large. The 100%/90% I mentioned above is the resolution, which can be adjusted through command + -/+. The default is 100% display, which is an overlapping state.

@Keith-CY
Copy link
Member

Keith-CY commented Jun 5, 2024

Screen.Recording.2024-06-05.at.19.10.13.mov

Overlapped in the last seconds.

BTW btc tx id is totally collapsed in the last seconds.

@FrederLu
Copy link

FrederLu commented Jun 6, 2024

ckb-explorer-frontend-in-magickbase-repo-iprxt1sye-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6 image There will be overlap between new icons and data on the RGB++ Digest pop-up window.

Any update on this conversation @Daryl-L

Pushed, just forgot to push the commit

https://ckb-explorer-frontend-in-magickbase-repo-nu9q7lqqs-magickbase.vercel.app/address/tb1qxu24tz3r27uxh3scl9qn2fe9j07t8r2ulcvve6

image The preview address has been updated and there should be new submissions, but the problem still exists. @Daryl-L
image image image

Previous overlapping issues were resolved.
However, there is a problem that the L2->L1 label is incompletely displayed on the address/transaction details page. When this problem occurs on the transaction details page, refreshing the page can display it normally. @Daryl-L

@Keith-CY Keith-CY merged commit a6b3a92 into develop Jun 7, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/add-redirect-link-to-digest-btc-txid branch June 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants